Python: Tweak LoopVariableCapture for performance #19325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joefarebrother
added
the
no-change-note-required
hvitved
reviewed
Apr 22, 2025
| isSink(node) and | ||
| ( | ||
| cs instanceof DataFlow::TupleElementContent or | ||
| cs.(DataFlow::TupleElementContent).getIndex() in [0 .. 10] or |
Contributor
There was a problem hiding this comment.
Another way to do this, which doesn't restrict the index, is to properly implement ContentSet, and then have a branch of ContentSet represent all possible TupleElementContents, like e.g. Ruby has a branch that represent all possible element contents.
Contributor
Author
There was a problem hiding this comment.
Indeed; but it seems like it would be quite a significant task to properly implement ContentSet for python.
tausbn
approved these changes
Apr 29, 2025
Contributor
tausbn
left a comment
tausbn
left a comment
There was a problem hiding this comment.
Looks good to me. Let's go with the quick fix for the time being. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the size of the
allowImplicitReadpredicate to improve performance on databases with a large number ofTupleElementContents.